Skip to content

feat(browser): add keyboard shortcuts menu, add Ctrl+D and Win+Tab shortcuts #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShuJun-Junical
Copy link

example

@MityaResh
Copy link

Hi. Your pullquest is interesting. I would suggest combining all components with shortcuts into one component. Example:

const keycode = KeyboardCodes.get('KeyD')!
const modifiers = new Modifiers();
modifiers.leftCtrl = true;
const label = t('keyboard.ctrlD');

return (
  <Shortcut keycode={keycode} modifiers={modifiers} label={label} />
);

@ShuJun-Junical
Copy link
Author

I have made modifications and merged all shortcuts into a reusable component shortcut.tsx

@ShuJun-Junical ShuJun-Junical requested a review from wj-xiao May 30, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants