fix: update korean localization #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MityaResh
reviewed
Jun 2, 2025
browser/src/i18n/locales/kr.ts
Outdated
| @@ -0,0 +1,69 @@ | |||
| const ko = { | |||
There was a problem hiding this comment.
What is the correct country code? ko or kr?
This file uses ko, but in browser/src/i18n/languages.ts and desktop/src/renderer/src/i18n/languages.ts uses kr. Maybe you should unify the country code?
There was a problem hiding this comment.
The Republic of Korea is kr in ISO 3166-1
There was a problem hiding this comment.
Sorry for mixing kr and ko.
I think ko (language code) is more appropriate because the code of 中文 is zh.
If you confirm this, I will fix it.
There was a problem hiding this comment.
Okay, you're right. As a native speaker, you have every right to choose the code ko. I just wish it was the same
There was a problem hiding this comment.
Thanks for your kind review!
I updated, please check again.
MityaResh
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Korean as one of the language options