Prevent warning logs when recording-method is pcap #2

[orgads]

If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as:

[core] Failed to open recording metadata file '(null)' for writing: Bad address

Prevent them by returning earlier.

Fixes #1889 for real this time.

Amends commit 759fd72.

[orgads]

The error is unrelated to my changes.

[rfuchs]

Why not just put the check in open_proc_meta_file and do the early return there?

[orgads]

Why not just put the check in open_proc_meta_file and do the early return there?

To avoid needless work until we reach there. Do you consider it negligible, and prefer to move it there?

[rfuchs]

Why not just put the check in open_proc_meta_file and do the early return there?

To avoid needless work until we reach there. Do you consider it negligible, and prefer to move it there?

Doesn't really matter. I was just thinking that if it had been there in the first place, then this second commit would have been unnecessary 😁 But no matter, will merge.

[orgads]

@rfuchs ping

I double-checked, and there are no other calls, so this should seal this case without extra work. If you still prefer to move the condition to open_proc_meta_file (and remove the previous fix as well), let me know and I'll update the PR.

[rfuchs]

Sorry for the delay, completely lost focus on this