Prevent warning logs when recording-method is pcap #2 #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier. Fixes sipwise#1889 for real this time. Amends commit 759fd72.
|
The error is unrelated to my changes. |
|
Why not just put the check in open_proc_meta_file and do the early return there? |
To avoid needless work until we reach there. Do you consider it negligible, and prefer to move it there? |
Doesn't really matter. I was just thinking that if it had been there in the first place, then this second commit would have been unnecessary 😁 But no matter, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as:
[core] Failed to open recording metadata file '(null)' for writing: Bad address
Prevent them by returning earlier.
Fixes #1889 for real this time.
Amends commit 759fd72.