Skip to content

Refactor MonorubyErr and Exception class. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 2, 2025
Merged

Refactor MonorubyErr and Exception class. #72

merged 11 commits into from
Jun 2, 2025

Conversation

sisshiki1969
Copy link
Owner

  • Refactor MonorubyErr and Exception class.
  • Support String#delete, String#ascii_only?, String.try_convert, Array#to_h.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 39.06936% with 694 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (21185a9) to head (85a4cfb).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
monoruby/src/builtins/string.rs 5.86% 273 Missing ⚠️
monoruby/src/builtins/kernel.rs 32.23% 103 Missing ⚠️
monoruby/src/globals/error.rs 45.00% 77 Missing ⚠️
monoruby/src/value.rs 38.46% 40 Missing ⚠️
monoruby/src/globals/store/class.rs 31.57% 26 Missing ⚠️
monoruby/src/builtins/module.rs 18.51% 22 Missing ⚠️
monoruby/src/value/rvalue.rs 41.66% 21 Missing ⚠️
monoruby/src/builtins/time.rs 0.00% 18 Missing ⚠️
monoruby/src/builtins/regexp.rs 21.05% 15 Missing ⚠️
monoruby/src/builtins/array.rs 87.87% 12 Missing ⚠️
... and 24 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #72       +/-   ##
===========================================
- Coverage   87.11%   72.07%   -15.05%     
===========================================
  Files         135      135               
  Lines       42113    42468      +355     
===========================================
- Hits        36686    30608     -6078     
- Misses       5427    11860     +6433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sisshiki1969 sisshiki1969 merged commit 36ded05 into master Jun 2, 2025
1 of 3 checks passed
@sisshiki1969 sisshiki1969 deleted the dev branch June 2, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant