BUGFIX: No double moving of nodes across dimensions if synced

[gradinarufelix]

In sync mode, moving a document node throws an error because Neos is already trying to move the document nodes across dimensions. This PR introduces an isActive flag which tells if the translation (with moving the nodes) is currently active, or not.

Then, an aspect avoids the Neos own moving across dimension if the nodes are in a dimension that is taken care of by the sync functionality of this package.

[mficzel]

I get that you want to prevent recursion but consider "active" a bit confusing. Because active is a positive thing while we want to prevent bad recursion.

Can we name this flag and the methods "recursionPreventionEnabled". That way we immediately get what they are for when we stumble over them in a year or two.

Also this would allow very explicit methods "enableRecursionPrevention", "disableRecursionPrevention", "isRecurSionPreventionEnabled" that future us will likely understand faster

[Copilot]

Pull Request Overview

This PR prevents Neos from moving node variants twice in sync mode by introducing a recursion-prevention flag and an AOP aspect to skip native moves when syncing.

• Added a recursionPreventionEnabled property and getter to coordinate disabling Neos’ native dimension moves.
• Wrapped afterAdoptNode and syncNode methods in NodeTranslationService to toggle the flag.
• Introduced an AroundMoveNodeDataAspect to intercept moveNodeData() and skip it when sync strategy is active.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
Classes/ContentRepository/NodeTranslationService.php	Added recursionPreventionEnabled flag, getter, and logic around adopt and sync operations.
Classes/Aop/AroundMoveNodeDataAspect.php	New AOP aspect to bypass Neos’ moveNodeData() when recursion prevention is enabled for sync translations.

Comments suppressed due to low confidence (1)

Classes/ContentRepository/NodeTranslationService.php:113

• Add unit tests for recursionPreventionEnabled behavior in NodeTranslationService and integration tests for AroundMoveNodeDataAspect to verify that native node moves are skipped when sync strategy is active.

    protected bool $recursionPreventionEnabled = true;

[Copilot]

Wrap the disabling and re-enabling of recursionPreventionEnabled in syncNode inside a try/finally block (as done in afterAdoptNode) to ensure the flag is always reset even if an exception occurs.

[Copilot]

Returning null here may not align with the original method’s return type (likely void). Consider using a bare return; or matching the original contract to avoid unexpected return values.

Suggested change

	return null;
	return;