BUGFIX: Snyc nodes on shutdown

[gradinarufelix]

If you move document nodes in sync mode, it leads to an error because it tries to move the content elements first. If you try to move document-2 into document-1 this leads to an error like Node path /sites/site/document-2/content does not start with /sites/site/document-1/document-2.

Another example from my test when moving a document node into another document node: Given path "/sites/neosdemo/features/other-elements" is not the beginning of "/sites/neosdemo/features/forms/other-elements/main/node53a18f52e9726", cannot get a relative path between them.

This PR solves the problem by collecting all nodes to be synced/translated and executing all of that on shutdown in an optimized order.

Because removed nodes are not available anymore at this stage, removed nodes must be stored as objects and not just as identifiers.

[Copilot]

Pull Request Overview

This PR fixes errors when moving document nodes in sync mode by batching node sync/translation operations at shutdown in an optimized order and storing removed nodes as objects.

• Switches signal connections from immediate publish to collection before publish and final translation on persistence flush
• Introduces a buffer (nodesToBeTranslated) and a translateNodes method triggered on allObjectsPersisted
• Injects the persistence manager and ensures all buffered nodes are persisted after translation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
Classes/Package.php	Updated signal-slot connections to collect and translate nodes on shutdown, injecting PersistenceManager
Classes/ContentRepository/NodeTranslationService.php	Added nodesToBeTranslated buffer, collectNodesToBeTranslated and translateNodes methods; injected persistence manager and adjusted sync logic

Comments suppressed due to low confidence (3)

Classes/ContentRepository/NodeTranslationService.php:218

• translateNodes contains critical batch-sync logic but appears untested; consider adding unit or integration tests to validate the ordering and handling of buffered nodes on shutdown.

    public function translateNodes(): void

Classes/Package.php:11

• Consider injecting the PersistenceManagerInterface instead of the concrete Doctrine PersistenceManager to follow interface-based dependency injection and improve testability.

use Neos\Flow\Persistence\Doctrine\PersistenceManager;

Classes/Package.php:29

• Verify that the PersistenceManager actually emits an 'allObjectsPersisted' signal—if the event name is incorrect or not emitted, the translateNodes method will never run.

        $dispatcher->connect(PersistenceManager::class, 'allObjectsPersisted', NodeTranslationService::class, 'translateNodes', false);

[mficzel]

Fine by 👀