added option --title-prefix to add to the 'MailCatcher' title #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble to see the difference between multiple mailcatcher instances
|
The builds broke, but I'm pretty sure those are not all caused by my changes. I had issues setting up a functioning build environment myself, but chose to not include my changes to that thinking I must have a weird setup making it not work. |
|
@sj26 I totally forgot about this, but I'm willing to spend some time on this (or a new) PR to try to get it into a usable/mergable state if you are interested. Just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first shot at adding an option to change the 'MailCatcher' title to be able to see the difference between multiple mailcatcher instances. I couldn't decide if it only should be an addition that it should be able to replace the whole title. In the end I settled for an addition, as it keeps the 'branding' in place.
See feature: #320
Please tell me if this is a valid fix for the issue, or that it needs to be done differently.