Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented ntsecdesc type conversion so ACEs return. #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yellephen
Copy link

I stayed up all night playing a CTF and all I found was a hash.

@yellephen
Copy link
Author

Hi skelsec, I made a pull request. Why did the enc dictionary of translations contain nTSecurityDescriptor and print out bad bytes? By commenting it out of there so the conversion fell through to the lookup table in the elif, the ACEs were loaded instead which is more useful information.

I like msldap because it works well which is what got me pulling on this thread.

@skelsec
Copy link
Owner

skelsec commented Feb 4, 2025

Hello, thank you for the PR!
May I ask what bad bytes are you referring to?
This PR will be rejected, because the nTSecurityDescriptor must be returning bytes or bytearray object, for two reasons:

  1. this would impact the API in a major way.
  2. Parsing nTSecurityDescriptor to an object takes a lof of resources, and some queroies could easily return hunderds of nTSecurityDescriptors which would slow down the app considerably

@yellephen
Copy link
Author

yellephen commented Feb 5, 2025

No bad bytes. I misinterpreted them. I like the objects. I'll see if I can get my script to handle the bytes else use my fork which uses code you had already written but didn't appear to be using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants