Skip to content

feat: rename step-results template to step-results-table and simplify it #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

FidelusAleksander
Copy link
Contributor

Changes

Checklist

  • I have added or updated appropriate labels to this PR
  • I have tested my changes
  • I have updated the documentation if needed

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 09:36
@FidelusAleksander FidelusAleksander marked this pull request as draft April 17, 2025 09:36
@github-actions github-actions bot added the templates Changes to the markdown templates label Apr 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Markdown template for rendering step results based on whether the step was passed or failed.

  • Added conditional rendering for passed/failed status with appropriate headings and images
  • Included a results table and an optional tips section

Copy link
Member

@chriswblake chriswblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplified look. I would just adjust the second column name/description.

@FidelusAleksander FidelusAleksander marked this pull request as ready for review April 18, 2025 10:28
@FidelusAleksander FidelusAleksander changed the title feat: add step-results-table template feat: rename step-results template to step-results-table and simplify it Apr 18, 2025
@FidelusAleksander FidelusAleksander merged commit 7aa2477 into main Apr 23, 2025
6 checks passed
@FidelusAleksander FidelusAleksander deleted the step-results-table branch April 23, 2025 15:45
@Shamsuoo
Copy link

nice

@FidelusAleksander FidelusAleksander added the bump-minor Corresponds to minor SemVer release label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-minor Corresponds to minor SemVer release templates Changes to the markdown templates
Development

Successfully merging this pull request may close these issues.

3 participants