Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-3499] Invoke configured hook address when dispatching hyperlane message #4

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

dhfang
Copy link
Contributor

@dhfang dhfang commented Oct 29, 2024

  • store hyperlane hook address in contract state
  • specify the hook in the hyperlane dispatch message

@dhfang dhfang requested a review from a team as a code owner October 29, 2024 05:55
@dhfang
Copy link
Contributor Author

dhfang commented Oct 29, 2024

@thal0x should I be making the same change to the solidity side for symmetry? if so, i'm not sure where the hook is specified in the solidity mailbox dispatch method arguments https://github.com/skip-mev/go-fast-contracts/blob/main/solidity/src/interfaces/hyperlane/IMailbox.sol#L54-L55

@thal0x
Copy link
Member

thal0x commented Oct 29, 2024

I know it's not necessarily important at the moment but for the sake of symmetry should we add this change to the Solidity contracts as well?

EDIT: I totally missed your comment above, let me figure out the answer

@thal0x
Copy link
Member

thal0x commented Oct 29, 2024

Lets just create a Linear task for adding this to the Solidity contract, it's a little unclear to me and doesn't feel worth spending time on right now IMO. But let me know if you disagree

@dhfang
Copy link
Contributor Author

dhfang commented Oct 29, 2024

Sounds good to me

@dhfang dhfang merged commit 0258c34 into main Oct 30, 2024
5 checks passed
@dhfang dhfang deleted the df/cw-gateway-specify-mailbox-hook-addr branch October 30, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants