Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): statically allocate a network and IP addresses (backport #124) #132

Open
wants to merge 4 commits into
base: release/v2.x.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 6, 2024

This basically makes Petri in control of the IP address management instead of docker. This makes it easier to get static IP addresses even if the container is stopped. Before this, the Docker provider would provide DNS names instead of IP addresses, which is undesirable due to CometBFT/the SDK not having good support for DNS hostnames.


This is an automatic backport of pull request #124 done by Mergify.

Zygimantass and others added 4 commits November 6, 2024 17:00
This basically makes Petri in control of the IP address management
instead of docker. This makes it easier to get static IP addresses
even if the container is stopped. Before this, the Docker provider
would provide DNS names instead of IP addresses, which is
undesirable due to CometBFT/the SDK not having good support for DNS
hostnames.

(cherry picked from commit 7ca1fb6)

# Conflicts:
#	core/go.mod
#	core/go.sum
#	core/provider/docker/docker_provider.go
#	core/provider/docker/network.go
#	core/provider/docker/task.go
Co-authored-by: Eric Warehime <[email protected]>
(cherry picked from commit 53bf574)
Co-authored-by: Eric Warehime <[email protected]>
(cherry picked from commit 797e392)
(cherry picked from commit 889bebb)

# Conflicts:
#	core/provider/docker/docker_provider.go
#	core/provider/docker/network.go
#	core/provider/docker/task.go
Copy link
Author

mergify bot commented Nov 6, 2024

Cherry-pick of 7ca1fb6 has failed:

On branch mergify/bp/release/v2.x.x/pr-124
Your branch is up to date with 'origin/release/v2.x.x'.

You are currently cherry-picking commit 7ca1fb6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/go.mod
	both modified:   core/go.sum
	both modified:   core/provider/docker/docker_provider.go
	both modified:   core/provider/docker/network.go
	both modified:   core/provider/docker/task.go

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 889bebb has failed:

On branch mergify/bp/release/v2.x.x/pr-124
Your branch is ahead of 'origin/release/v2.x.x' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 889bebb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/provider/docker/docker_provider.go
	both modified:   core/provider/docker/network.go
	both modified:   core/provider/docker/task.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant