Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): improve recognition of exit codes (backport #135) #138

Open
wants to merge 1 commit into
base: release/v1.x.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 7, 2024

currently, both DO and Docker providers do not wait for the container to exit until returning an exit code. this introduces a condition, where the container hasn't exited yet (e.g. with an error), but we already fetch it's stdout and exit code (which at that point is 0). this commit makes the providers wait for the exec container to finish and only then returns the response.


This is an automatic backport of pull request #135 done by Mergify.

currently, both DO and Docker providers do not wait for the container to
exit until returning an exit code. this introduces a condition, where
the container hasn't exited yet (e.g. with an error), but we already
fetch it's stdout and exit code (which at that point is 0). this commit
makes the providers wait for the exec container to finish and only then
returns the response.

(cherry picked from commit 4a67052)

# Conflicts:
#	core/provider/digitalocean/task.go
#	core/provider/docker/task.go
#	cosmos/node/init.go
Copy link
Author

mergify bot commented Nov 7, 2024

Cherry-pick of 4a67052 has failed:

On branch mergify/bp/release/v1.x.x/pr-135
Your branch is up to date with 'origin/release/v1.x.x'.

You are currently cherry-picking commit 4a67052.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cosmos/node/genesis.go
	modified:   cosmos/node/keys.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/provider/digitalocean/task.go
	both modified:   core/provider/docker/task.go
	both modified:   cosmos/node/init.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant