Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement SimulateSwapExactAssetInWithMetadata for hallswap adapter #112

Merged
merged 2 commits into from
May 10, 2024
Merged

implement SimulateSwapExactAssetInWithMetadata for hallswap adapter #112

merged 2 commits into from
May 10, 2024

Conversation

thal0x
Copy link
Member

@thal0x thal0x commented May 10, 2024

No description provided.

@thal0x thal0x self-assigned this May 10, 2024
NotJeremyLiu
NotJeremyLiu approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@NotJeremyLiu NotJeremyLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just return none for spot price now, with the expectation the api will pass in false for the include spot price bool, we can revisits spot price / price impact in the future

@thal0x thal0x merged commit ce53425 into main May 10, 2024
5 checks passed
@thal0x thal0x deleted the jw/hallswap-simulate-metadata branch May 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotJeremyLiu NotJeremyLiu NotJeremyLiu approved these changes

Assignees

@thal0x thal0x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thal0x @NotJeremyLiu