[API-3578] Fundrebalancer ERC20 approvals #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattac21
commented
Nov 15, 2024
| @@ -309,34 +306,6 @@ func (r configReader) Config() Config { | |||
| return r.config | |||
| } | |||
|
|
|||
| func (r configReader) GetSolverAddress(domain uint32, environment ChainEnvironment) (string, []byte, error) { | |||
mattac21
commented
Nov 15, 2024
| @@ -168,12 +168,22 @@ func WithEstimatedGasTipCap() TxBuildOption { | |||
|
|
|||
| func WithEstimatedGasFeeCap() TxBuildOption { | |||
| return func(ctx context.Context, b TxBuilder, tx *types.DynamicFeeTx) error { | |||
| price, err := b.rpc.SuggestGasPrice(ctx) | |||
There was a problem hiding this comment.
this doesn't always work for 1559 tx's, so I changed it to how the client estimates the gas fee cap by taking the gas tip cap + (base fee of the most recent block * 2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.