Make the search more defensive against invalid or missing emojis #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think Cloud Confluence may have updated recently or something, but I've found in the last couple weeks or so, a lot of my searches were failing.
I opened up the Workflow Debugger and found that the search was raising an exception in the
ast
module. Luckily, there's only one usage ofast
in the script.Basically, I believe that Confluence has made an API change that made the original code error out on pages that don't define an emoji. I figured a
try/except
pattern would be more appropriate here; make a best effort to show the page's emoji, but if absolutely anything goes wrong with that process, just give up and show the search result without the emoji, since it's not critical.