Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the search more defensive against invalid or missing emojis #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phantom-jacob
Copy link

I think Cloud Confluence may have updated recently or something, but I've found in the last couple weeks or so, a lot of my searches were failing.

I opened up the Workflow Debugger and found that the search was raising an exception in the ast module. Luckily, there's only one usage of ast in the script.

Basically, I believe that Confluence has made an API change that made the original code error out on pages that don't define an emoji. I figured a try/except pattern would be more appropriate here; make a best effort to show the page's emoji, but if absolutely anything goes wrong with that process, just give up and show the search result without the emoji, since it's not critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant