Skip to content

Better log for failure during resource deletion/creation #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2025
Merged

Better log for failure during resource deletion/creation #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91b5fdd
Better log for failure during resource deletion/creation
im-konge Nov 5, 2025
31238f8
add exception message to the runtime exceptions
im-konge Nov 6, 2025
2f3b8e6
just one check
im-konge Nov 6, 2025
2adf57d
Merge branch 'main' into better-logging-during-exception
im-konge Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 53 additions & 21 deletions test-frame-common/src/main/java/io/skodjob/testframe/resources/KubeResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,11 +511,19 @@ private <T extends HasMetadata> void createOrUpdateResource(
try {
cf.get(TestFrameConstants.GLOBAL_TIMEOUT_MEDIUM, TimeUnit.MILLISECONDS);
} catch (TimeoutException e) {
LOGGER.error("Timeout waiting for resource to be ready", e);
throw new RuntimeException(e);
LOGGER.error("Timeout waiting for resource {}/{} to be ready",
resource.getMetadata().getNamespace(),
resource.getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
} catch (InterruptedException | ExecutionException e) {
LOGGER.error("Exception during wait for resources to be ready", e);
throw new RuntimeException(e);
LOGGER.error("Exception during wait for resource {}/{} to be ready",
resource.getMetadata().getNamespace(),
resource.getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
}
}
}
Expand All @@ -540,11 +548,19 @@ private <T extends HasMetadata> void createOrUpdateResource(
try {
cf.get(type.getTimeoutForResourceReadiness(), TimeUnit.MILLISECONDS);
} catch (TimeoutException e) {
LOGGER.error("Timeout waiting for resource to be ready", e);
throw new RuntimeException(e);
LOGGER.error("Timeout waiting for resource {}/{} to be ready",
resource.getMetadata().getNamespace(),
resource.getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
} catch (InterruptedException | ExecutionException e) {
LOGGER.error("Exception during wait for resource to be ready", e);
throw new RuntimeException(e);
LOGGER.error("Exception during wait for resource {}/{} to be ready",
resource.getMetadata().getNamespace(),
resource.getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
}
}
}
Expand All @@ -556,7 +572,7 @@ private <T extends HasMetadata> void createOrUpdateResource(
CompletableFuture.allOf(waiters.toArray(new CompletableFuture[0])).get();
} catch (InterruptedException | ExecutionException e) {
LOGGER.error("Exception during wait for resources to be ready", e);
throw new RuntimeException(e);
throw new RuntimeException(e.getMessage(), e);
}
}
}
Expand Down Expand Up @@ -820,7 +836,7 @@ public void deleteResources(boolean async) {
try {
item.throwableRunner().run();
} catch (Exception e) {
throw new RuntimeException(e);
throw new RuntimeException(e.getMessage(), e);
}
}, EXECUTOR);
if (async) {
Expand All @@ -829,11 +845,19 @@ public void deleteResources(boolean async) {
try {
cf.get(TestFrameConstants.GLOBAL_TIMEOUT, TimeUnit.MILLISECONDS);
} catch (TimeoutException e) {
LOGGER.error("Timeout waiting for deletion of resource", e);
throw new RuntimeException(e);
LOGGER.error("Timeout waiting for deletion of resource {}/{}",
item.resource().getMetadata().getNamespace(),
item.resource().getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
} catch (InterruptedException | ExecutionException e) {
LOGGER.error("Exception during deletion or wait for resource to be deleted", e);
throw new RuntimeException(e);
LOGGER.error("Exception during deletion or wait for resource {}/{} to be deleted",
item.resource().getMetadata().getNamespace(),
item.resource().getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
}
}
count.decrementAndGet();
Expand All @@ -860,10 +884,10 @@ public void deleteResources(boolean async) {
.get(TestFrameConstants.GLOBAL_TIMEOUT, TimeUnit.MILLISECONDS);
} catch (TimeoutException e) {
LOGGER.error("Timeout exception during wait for resources to be deleted");
throw new RuntimeException(e);
throw new RuntimeException(e.getMessage(), e);
} catch (InterruptedException | ExecutionException e) {
LOGGER.error("Exception during wait for resources to be deleted", e);
throw new RuntimeException(e);
throw new RuntimeException(e.getMessage(), e);
}
}
}
Expand Down Expand Up @@ -915,7 +939,7 @@ private void writeResourceAsYaml(HasMetadata res) {
(res.getMetadata().getNamespace() == null ? "" : res.getMetadata().getNamespace() + "-") +
res.getMetadata().getName() + ".yaml"), yaml, StandardCharsets.UTF_8);
} catch (IOException e) {
throw new RuntimeException(e);
throw new RuntimeException(e.getMessage(), e);
}
}
}
Expand All @@ -931,11 +955,19 @@ private void writeResourceAsYaml(HasMetadata res) {
try {
cf.get(TestFrameConstants.GLOBAL_TIMEOUT, TimeUnit.MILLISECONDS);
} catch (TimeoutException e) {
LOGGER.error("Timeout waiting for deletion of resource", e);
throw new RuntimeException(e);
LOGGER.error("Timeout waiting for deletion of resource {}/{}",
res.getMetadata().getNamespace(),
res.getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
} catch (InterruptedException | ExecutionException e) {
LOGGER.error("Exception during wait for resource to be deleted", e);
throw new RuntimeException(e);
LOGGER.error("Exception during wait for resource {}/{} to be deleted",
res.getMetadata().getNamespace(),
res.getMetadata().getName(),
e
);
throw new RuntimeException(e.getMessage(), e);
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...rame-common/src/test/java/io/skodjob/testframe/resources/KubeResourceManagerMockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,11 @@ void testHandleAsyncDeletionBeingCalled() {
@Test
void testHandleAsyncDeletionThrowsException() {
CompletableFuture<Void> cf = CompletableFuture.runAsync(() -> {
throw new RuntimeException();
throw new RuntimeException("This is test exception");
});

assertThrows(RuntimeException.class, () -> kubeResourceManager.handleAsyncDeletion(List.of(cf)));
RuntimeException runtimeException = assertThrows(RuntimeException.class,
() -> kubeResourceManager.handleAsyncDeletion(List.of(cf)));
assertTrue(runtimeException.getMessage().contains("This is test exception"));
}
}
Loading