pre-commit setup #1112
Open
pre-commit setup #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBossan
requested changes
Jul 23, 2025
There was a problem hiding this comment.
Thanks for the PR. After skimming through the files, overall, the changes look acceptable and I think we will be able to proceed.
Before doing that, could you please:
- Remove docs/examples from the checked folders? Maybe we can add them later but for now I think they're not necessary.
- Let's add a step to the
tests.ymlto run the checkers+linters to ensure that the code stays in a good shape. - "flake8 still has some failures": I think we should be able to fix those, but it's probably better done in a separate PR. Would you be willing to create that?
| neptune_installed = False | ||
| try: | ||
| # pylint: disable=unused-import | ||
| import neptune |
There was a problem hiding this comment.
This change, and the ones below, are really strange, any idea what caused it?
| ['sequential.{}.weight'.format(i) for i in linear_idcs[:-1]] + | ||
| ['sequential.{}.bias'.format(i) for i in linear_idcs[:-1]] | ||
| ['sequential.{}.weight'.format(i) for i in linear_idcs[:-1]] | ||
| + ['sequential.{}.bias'.format(i) for i in linear_idcs[:-1]] |
There was a problem hiding this comment.
This type of change is uglier than what we had previously, but I guess there is no setting for this, so we can accept it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that showcases the diff between files after
pre-commit run --all-filesis executed. flake8 still has some failures:3 E402 module level import not at top of file
1 E713 test for membership should be 'not in'
5 E721 do not compare types, for exact checks use
is/is not, for instance checks useisinstance()1 E722 do not use bare 'except'
4 E731 do not assign a lambda expression, use a def
5 E741 ambiguous variable name 'l'
1 F541 f-string is missing placeholders
1 F824
global _linkcode_git_revisionis unused: name is never assigned in scopeCould you please let me know your thoughts?
cc: @BenjaminBossan