fix(Admin.UI): fix display of idp properties #239
Merged
+43
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rosenbach |
|
Hi @skoruba, I noticed that this PR didn't make it into the main branch. Is there anything that I can do to improve it, so we can bring it into the app? The bug still persists. |
|
I am sorry Michael for the delay, I merged it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the initialization of properties in the detail view of an Identity Provider in the AdminUI.
The problem is that at the moment, if the property has certain characters, the actual value does not get inserted into the view. Hence, if you do not realize this, and submit the form afterwards, you might end up accidentally altering properties. 😵
The fix happens through a simplification of the whole initialization process: instead of json-encoding it and sending it around via JS (that was the process where the problem originated), we employ more server-side razor-capabilities and remove some of the previous logic. Like that, we can avoid doing some json-encoding completely 🎉
New behaviour:
Old behaviour:
