New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(username-validation): remove regex #240

Open

rosenbach wants to merge 2 commits into skoruba:main from rosenbach:remove-username-regex

Contributor

rosenbach commented Oct 24, 2024

Right now there's a regex on the username property of the UserDto, which is a problem because:

It is not configurable (the current regex is a problem for German names 😢)
(and more important) Even if it is changed in the source code, the username will still be checked against the UserOptions.AllowedUserNameCharacters Property, which can be configured via appsettings (Defaults to abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@+). So you would need to change the regex on two positions.

With the help of this PR, the AspNetCore.Identity Regex will be used exclusively.

This PR fixes #156

rosenbach added 2 commits

October 24, 2024 15:18


          chore(username-validation): remove regex

95e1334


          chore(username-validation): undo reordering of usings

91b4b66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet