Fixes skupperproject#1797: Also count discretionary co-records #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/vanflow.c
Outdated
| @@ -1860,7 +1860,8 @@ vflow_record_t *vflow_start_record(vflow_record_type_t record_type, vflow_record | |||
| if (0 == sys_atomic_get(&state->emit_discretionary_records)) { | |||
| return 0; | |||
| } | |||
| if (sys_atomic_inc(&state->discretionary_record_count) >= DISCRETIONARY_RECORDS_STOP_THRESHOLD) { | |||
| int val; | |||
There was a problem hiding this comment.
Suggested change
| int val; | |
| uint32_t val; |
There was a problem hiding this comment.
Hi Mick - Can you please change the commit message on the PR to -
Fixes #1797 - Assigned return value of sys_atomic_inc to a variable before comparing it to DISCRETIONARY_RECORDS_STOP_THRESHOLD
That is the standard commit message we use when issues are being fixed. When the PR is merged to main, the issue referenced after the Fixes is automatically closed by github
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
=======================================
- Coverage 68.5% 66.7% -1.8%
=======================================
Files 207 201 -6
Lines 46119 46943 +824
Branches 5121 5258 +137
=======================================
- Hits 31608 31334 -274
- Misses 12341 13694 +1353
+ Partials 2170 1915 -255
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ted-ross
approved these changes
Jun 13, 2025
ganeshmurthy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why, but both failing tests pass 10 times in a row with this change.