This repository was archived by the owner on Sep 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
add parity service #11
Open
daimesava
wants to merge
6
commits into
master
Choose a base branch
from
add-parity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godsflaw
suggested changes
Mar 23, 2020
| - `SERVER_ETH_RPC_HOST`: URL to ETH Parity node | ||
| - `SERVER_ETH_RPC_PORT`: ETH RPC port | ||
| - `SERVER_ETH_RPC_HOST`: URL to ETH Parity node. If using parity from this repository use `http://parity` | ||
| - `SERVER_ETH_RPC_PORT`: ETH RPC port |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this now to 127.0.0.1 for the SERVER_ETH_RPC_HOST as one of the new dynamic gas models gets gas prices from the node and uses both SERVER_ETH_RPC_HOST and SERVER_ETH_RPC_PORT.
| - `SERVER_ETH_RPC_HOST`: URL to ETH Parity node | ||
| - `SERVER_ETH_RPC_PORT`: ETH RPC port | ||
| - `SERVER_ETH_RPC_HOST`: URL to ETH Parity node. If using parity from this repository use `http://parity` | ||
| - `SERVER_ETH_RPC_PORT`: ETH RPC port |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above about dynamic gas model.
| "--no-ws", | ||
| "--min-peers=25", | ||
| "--max-peers=50", | ||
| "--no-ancient-blocks" |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add --cache-size=8192 here, the default is too small.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.