Fix embed selection issues #4464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the right guard node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes an issue when the selection ends on or the cursor is at the innermost part (offset 0) of the right guard of an embed blot.
<left guard><embed content node>|cursor|<right guard>Two common cases that this solves:
The implementation suggestion is to let the leaf blot (as embed inherits from leaf) calculate the index offset even if it is at offset 0. Looking at the base implementation for the leaf and text blots is seems safe to change the order here. Another option is to add an extra check specifically for embed blots but that seems redundant if I am not missing something.