fix: introduce the packaging dependency #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to resolve #29 where the
packaging
dependency is not installed on the system.It seems like
pip
which uses thepackaging
project duplicates the logic into its source code rather then installing it as a dependency. Seems like the chicken and egg problem 🥚This PR aims to introduce
packaging
as a dependency to the project, alternatively we could duplicate the logic likepip
does, or find another solution rather then adding our first "real" dependencyTesting
slack create -t https://github.com/slack-samples/bolt-python-custom-function-template
requirements.txt
file so that it only contains (many other packages have thepackaging
dependency)slack update
Special notes
Important to not that many python development tools like
pip
,black
andpytest
use thepackaging
project, this is why we did not catch this error soonerRequirements
./scripts/install_and_run_tests.sh
after making the changes.