nebula-cert: support reading CA passphrase from env #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch extends the `nebula-cert` command to support reading the CA passphrase from the environment variable `CA_PASSPHRASE`. Currently `nebula-cert` depends in an interactive session to obtain the CA passphrase. This presents a challenge for automation tools like ansible. With this change, ansible can store the CA passphrase in a vault and supply it to `nebula-cert` via the `CA_PASSPHRASE` environment variable for non-interactive signing. Signed-off-by: Hal Martin <[email protected]>
|
Thanks for the contribution! Before we can merge this, we need @halmartin to sign the Salesforce Inc. Contributor License Agreement. |
|
I'm not sure why the status of this hasn't updated, but I have already signed the CLA:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the
nebula-certcommand to support reading the CA passphrase from the environment variableCA_PASSPHRASE.Currently
nebula-certrequires an interactive session to obtain the CA passphrase. This presents a challenge for automation tools like ansible. With this change, ansible can store the CA passphrase in a vault and supply it tonebula-certvia theCA_PASSPHRASEenvironment variable for non-interactive signing.This allows the user to preserve the security of the CA certificate by encrypting it at rest (#386) while also enabling the use of automation tools that can securely store and provide the CA password to automate certificate signing operations.
Let me know if there are any technical or stylistic issues with this PR and I'll try my best to fix them :)