linux: opt out of naming your tun device yourself #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmaguire
reviewed
Oct 6, 2025
overlay/tun_linux.go
Outdated
| } | ||
| if good { | ||
| if len(candidateName) > 16 { | ||
| return "", errors.New("you have too many nebula networks") |
There was a problem hiding this comment.
I think it would be nice to be a little bit more clear about exactly what's going on here in order to make this error actionable. It's actually OK to have this many nebula networks, but we can't fit the tun name.
There was a problem hiding this comment.
Could also be a pre-flight check and should be included the example config comments/docs. Can't compute a name shorter than unix.IFNAMSIZ if the tunNameTemplate is longer than it to begin with.
JackDoan
force-pushed
the
tun-name-template
branch
from
e1e8fb8 to
36daea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to end your
tun.devname setting with%dto tell Nebula "please find the lowest-numbered interface that matches this pattern and use it"I'm honestly not sure what would be needed to bring this to other platforms. I think Mac OS mostly doesn't care. Windows seems like it will need different handling as well, but won't break with this change.