-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Pillar Size and Spacing #5141
Open
HCroc
wants to merge
3
commits into
slic3r:master
Choose a base branch
from
HCroc:HCroc-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I understand from the pillar supports in this supportmaterial.pm, is that they produce the same width pillars for different sized objects. In response to issue slic3r#3485, rather then making 'pillar size and spacing' a changeable variable in the UI it could be interesting to have these variables changed automatically depending on the size of the object. The altercations I have made to this code allows for a pillar size and spaces which change depending on the width of the object. It does this by using the square root of the x width and then using that number to create a suitable pillar width for the pillars. I am new to perl and not a mathematician so this may not be the best way for going about doing this variable pillar widths. Either way, I hope this might come in handy in some way. Notes: I had to change the Margin Step to MARGIN/1 to get the pillars built in squares at the edge. This also did not work on a cube smaller then 15mm as it removed the outer walls, but did work on another test model smaller then 20mm so I don't know what that error is but believe it is due to "my $x_max_pillar = $x_max_squared/1000;".
Variable Pillar Sizes for SupportMaterial.pm From what I understand from the pillar supports in this supportmaterial.pm, is that they produce the same width pillars for different sized objects. In response to issue slic3r#3485, rather then making 'pillar size and spacing' a changeable variable in the UI it could be interesting to have these variables changed automatically depending on the size of the object. The altercations I have made to this code allows for a pillar size and spaces which change depending on the width of the object. It does this by using the square root of the x width and then using that number to create a suitable pillar width for the pillars. I am new to perl and not a mathematician so this may not be the best way for going about doing this variable pillar widths. Either way, I hope this might come in handy in some way. Notes: I had to change the Margin Step to MARGIN/1 to get the pillars built in squares at the edge. This also did not work on a cube smaller then 15mm as it removed the outer walls, but did work on another test model smaller then 20mm so I don't know what that error is but believe it is due to "my $x_max_pillar = $x_max_squared/1000;".
Variable Pillar Sizes for SupportMaterial.pm From what I understand from the pillar supports in this supportmaterial.pm, is that they produce the same width pillars for different sized objects. In response to issue slic3r#3485, rather then making 'pillar size and spacing' a changeable variable in the UI it could be interesting to have these variables changed automatically depending on the size of the object. The altercations I have made to this code allows for a pillar size and spaces which change depending on the width of the object. It does this by using the square root of the x width and then using that number to create a suitable pillar width for the pillars. I am new to perl and not a mathematician so this may not be the best way for going about doing this variable pillar widths. Either way, I hope this might come in handy in some way. Notes: I had to change the Margin Step to MARGIN/1 to get the pillars built in squares at the edge. Tested in application and worked but I have not printed it yet. This also did not work on a cube smaller then 15mm as it removed the outer walls, but did work on another test model smaller then 15mm so I don't know what that error is but believe it is due to "my $x_max_pillar = $x_max_squared/1000;".
❌ Build Slic3r 1.3.0-master-2512 failed (commit 01a080fd3d by @HCroc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I understand from the pillar supports in this supportmaterial.pm, is that they produce the same width pillars for different sized objects. In response to issue #3485, rather then making 'pillar size and spacing' a changeable variable in the UI it could be interesting to have these variables changed automatically depending on the size of the object. The altercations I have made to this code allows for a pillar size and spaces which change depending on the width of the object.
It does this by using the square root of the x width and then using that number to create a suitable pillar width and space for the pillars. I am new to perl and not a mathematician so this may not be the best way for going about doing this variable pillar widths. Either way, I hope this might come in handy in some way.
Current Pillar Structure:

Auto Resized Pillar Structure (Different pillar size for the smaller and bigger cubes):

Notes: I had to change the Margin Step to MARGIN/1 to get the pillars built in squares at the edge. This also did not work on a cube smaller then 15mm as it removed the outer walls, but did work on another test model smaller then 20mm so I don't know what that error is but believe it is due to "my $x_max_pillar = $x_max_squared/1000;". I'm also new to github so let me know if I have posted this in the wrong place.
Current:

Auto Resized:

