Skip to content

Conversation

@jozefizso
Copy link
Member

Teams working on this project are not public so we must list individual accounts as owners.

Teams working on this project are not public so we must list individual accounts as owners.
@jozefizso jozefizso requested a review from lakeron October 8, 2025 15:29
@jozefizso jozefizso self-assigned this Oct 8, 2025
@jozefizso jozefizso added the documentation Improvements or additions to documentation label Oct 8, 2025
# markdown-cli tool code owners

# Source code is owned by @slidoapp/team-presentations team
* @DominikPalo @jozefizso @m-kovac @filipbodor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use team handle, expect specific team member handle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the @slidoapp/team-presentations team is private, we cannot use it anyway.

There's also UX problem on GitHub when teams are owners as only the team will be tagged for PR review and if we need multiple approvals, only the first team member doing the approval will be listed in the Reviewers. All the other members will not see the PR as required anymore.

@jozefizso jozefizso requested a review from lakeron October 24, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants