-
Notifications
You must be signed in to change notification settings - Fork 46
change interface to add support of psr/http-message:2.0 #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change interface to add support of psr/http-message:2.0 #237
Conversation
composer.json
Outdated
@@ -38,7 +38,7 @@ | |||
"ext-json": "*", | |||
"ext-libxml": "*", | |||
"psr/http-factory": "^1.0", | |||
"psr/http-message": "^1.1" | |||
"psr/http-message": "^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem to pass with 1.1 too, maybe relax to "^1.1 | ^2.0"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the delay. Seems reasonable, added
The composer.lock doesn't work for PHP 8.0, so rather than use the lock file, do a composer update.
Thanks. |
Hello, These changes prevent proper I can no longer do: return $response
->withStatus(StatusCode::STATUS_OK)
->withFile($myFile); because with this PR the return type of withStatus is not Wouldn’t returning |
No description provided.