feature/fontique: Remove fontdb, adapt glyph embedding code #9434
+115
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One problem I was having with the embedding code is that it wants to know the original paths that fonts were loaded from, and as fontique collections only register fonts from byte blobs this information was not available. But I've just realized that I can keep this information seperate for the custom fonts. |
|
Software screenshot tests seem to be scaling. I think a font isn't getting correctly sized somewhere? |
expenses
force-pushed
the
fontique-everywhere
branch
from
26358c7 to
978c114
Compare
expenses
force-pushed
the
fontique-everywhere
branch
from
978c114 to
c861783
Compare
|
I've reworked this. It's not ready to merge and fontdb isn't removed yet but it's a lot better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not finished but I'm making a PR now so that CI will run. I'm not very happy with the changes to embed_glyphs.rs but am not sure what I should be doing there really.