Respect the NO_COLOR environment variable #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See <https://no-color.org/> Support for CLICOLOR and CLICOLOR_FORCE is a bigger change, and will have to wait till v2.10. See <https://bixense.com/clicolors/> for more details.
Techcable
force-pushed
the
fix/respsect-no-color
branch
from
96650be to
a6f335d
Compare
dpc
reviewed
Aug 22, 2025
| impl AnyTerminal { | ||
| fn should_use_color(&self) -> bool { | ||
| // Respect NO_COLOR <https://no-color.org/> | ||
| if std::env::var_os("NO_COLOR").map_or(false, |x| !x.is_empty()) { |
Contributor
There was a problem hiding this comment.
Suspcion: Might be slow, might want to wrap it in OnceLock or something like it.
Member
Author
There was a problem hiding this comment.
This is only called from TermDecoratorBuilder and we already do a isatty call on stdout/stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://no-color.org/
Support for CLICOLOR and CLICOLOR_FORCE is a bigger change,
and will have to wait till v2.10.
See https://bixense.com/clicolors/ for more details.