-
Notifications
You must be signed in to change notification settings - Fork 32
Add conference-call-like features (audio menu, caller pin, dtmf menu) #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrscotty
wants to merge
13
commits into
slomkowski:master
Choose a base branch
from
mrscotty:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the user to be self_mute and self_deaf when there is no SIP call active. Users in other Mumble groups can then see whether the user is active without moving to same group. Note: this needs the updated mumlib with the self_mute and self_deaf methods
i.e. turning deaf on auto-mutes and turning mute automatically turns off deafen
caller must enter pin before being unmuted/undeafened in mumble room
- playAudioFile() makes it possible to play a WAV file to either the caller or the mumble channel - menu skeleton has DTMF handling and is ready for adding '*n' functions (like *5 = mute).
In config.ini, add the [pins] section, with key/value entries for the expected pin and the channel regex to switch to when the caller enters the pin. Here's an example: [pins] 12345 = DevOps Team 23456 = Sales Team
@mrscotty hello hope you are doing good and these are some great effort to make changes. where i can find the master file with all the changes made. Regards, |
Hi Salik,
I'm not sure what you mean by "the master file with all the changes made".
Take a look at the pull request [#18], which containes a series of the 12 Git commits I made during development.
In README.md, see the sections "Multi-Line Support", "Caller PIN", "Autodeaf" and "Audio Files". The file config.ini.example also contains some example entries.
Best regards,
Scott
… On Dec 18, 2017, at 11:57, satti001 ***@***.***> wrote:
@mrscotty hello hope you are doing good and these are some great effort to make changes. where i can find the master file with all the changes made.
Regards,
salik
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: These commits depend on slomkowski/mumlib#14
These conference-call-like features include:
autodeaf: When mumsi connects to mumble, the user is auto-deafened. When the SIP call is answered, the user is auto-undeafened/unmuted. This allows mumble users to see the mumsi status in the overview, even when they are in a different channel.
dtmf menu: A basic menu structure for DTMF commands is included, which will eventually support things like '*5' for self-mute, etc. For now, it supports the caller pin entry.
caller pin entry: Allows the SIP caller to be forced to enter a pin before being allowed to enter the mumble channel. This helps keep eavesdroppers out!
playAudioFile(): This plays WAV files to either the caller or the mumble channel. The wave files are configurable in the config.ini. Currently, it is used for the welcome message, pin prompt, and the goodbye message when hanging up after wrong pin was entered. It also plays a "caller entering chat" message to make sure other users notice when someone new joins.