Feat: Supporting immediate values without # #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
feat-sup-imm-WO-hashtahPrefix
branch
5 times, most recently
from
41f1118 to
b6c27ec
Compare
willieyz
force-pushed
the
feat-sup-imm-WO-hashtahPrefix
branch
4 times, most recently
from
1a499ae to
b4e08a3
Compare
mkannwischer
force-pushed
the
feat-sup-imm-WO-hashtahPrefix
branch
from
b4e08a3 to
f3aa07b
Compare
mkannwischer
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Thanks @willieyz. Great & simple improvement that is long overdue.
- This commit suppoting immediate values without # - Following model are supported: - aarch64 - arch_v7m - arch_v81m 1. The imm_pattern was updated to recognize immediate values regardless of the presence of #, and the <imm> prefix strip off logic was adjusted accordingly. Additionally, commas `,` were removed from `imm_pattern` to avoid misinterpreting operands like `q2, UXTW 2` as a single immediate: ``` .syntax unified start: vstrw.32 q0, [r0, #16] vstrw.u32 q0, [r0, q2, UXTW 2]. end: ``` 2. Also, since we now allow immediate values both with and without #, we need a way to distinguish true immediates from registers. ``` add x0, x1, x2 ; x2 is a register add x0, x1, 123 ; 123 is an immediate ``` In the current pattern, x2 could be incorrectly interpreted as an immediate, which is unacceptable. To resolve this, we replace `\w+` with a stricter pattern: `(0[xb])?[0-9a-fA-F]+` This ensures only valid numeric literals (decimal or hex) are treated as immediates. 3. For the immediate value example: `vrshr.s32 q0, q1, #(SHIFT)`, in order to support the alias like this, the old and new immediate patterns are now combined, enabling both literal and symbolic forms. Signed-off-by: willieyz <[email protected]>
mkannwischer
force-pushed
the
feat-sup-imm-WO-hashtahPrefix
branch
from
f3aa07b to
a29dbf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#aarch64arch_v7march_v81mimm_patternwas updated to recognize immediate values regardless of the presence of#, and the<imm>prefix strip off logic was adjusted accordingly.,were removed fromimm_patternto avoid misinterpreting operands likeq2, UXTW 2as a single immediate:#(SHIFT), used in instructions such as follow, we now combine the old symbolic-style and the new numeric literal patterns. This allows both formats to be parsed properly.