removed unnecessary "data": null if request failed before execution#2225
Closed
mskacelik wants to merge 2 commits intosmallrye:mainfrom
Closed
removed unnecessary "data": null if request failed before execution#2225mskacelik wants to merge 2 commits intosmallrye:mainfrom
mskacelik wants to merge 2 commits intosmallrye:mainfrom
Conversation
jmartisk
reviewed
Nov 11, 2024
...ntegration-tests/src/test/java/io/smallrye/graphql/tests/customscalars/CustomScalarTest.java
Outdated
Show resolved
Hide resolved
…via GraphQL specification)
mskacelik
force-pushed
the
issue-2081
branch
from
868c5c8 to
8b5bcd1
Compare
jmartisk
previously approved these changes
Nov 11, 2024
Contributor
Author
|
Quarkus branch: https://github.com/mskacelik/quarkus/tree/srgql-2.11.1 |
mskacelik
force-pushed
the
issue-2081
branch
from
e8c1a4e to
7a4d404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://spec.graphql.org/draft/#sec-Response-Format
The only exception is our bean validation, responses during an error contain this field:
There was no need to change anything on the client side.
fix:#2081