Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary "data": null if request failed before execution #2225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mskacelik
Copy link
Contributor

@mskacelik mskacelik commented Nov 11, 2024

https://spec.graphql.org/draft/#sec-Response-Format

If the request included execution, the response map must contain an entry with key data. The value of this entry is described in the “Data” section. If the request failed before execution due to a syntax error, missing information, or validation error, this entry must not be present.

The only exception is our bean validation, responses during an error contain this field:

"data" : {
    operationName: null
}

There was no need to change anything on the client side.

fix:#2081

jmartisk
jmartisk previously approved these changes Nov 11, 2024
@mskacelik
Copy link
Contributor Author

mskacelik commented Nov 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants