Deferred completionStage when executing HTTP Async calls in VertxTypesafeGraphQLClientProxy

[lacoonte]

Fixes #2293 and #2300

[jmartisk]

The code looks good IMO (except you need to run the formatter plugin, the CI is complaining).

About testing... Do you have an idea how to easily test this? I think we don't have suitable infrastructure in place for stopping/starting servers, but AFAIU the retry also applies to when the server returns an error, so we could test it with a server that returns an error on the first invocation and succeeds on the second? Maybe you have a better idea...?

[lacoonte]

@jmartisk server returning an error is enough for this :) do you have an example of a test class related to this pr? Today i will have some time to finish it

[jmartisk]

@lacoonte, If you're looking for tests that use a similar architecture and can be used for inspiration, look for example at https://github.com/smallrye/smallrye-graphql/blob/main/server/integration-tests/src/test/java/io/smallrye/graphql/tests/client/typesafe/RecordAsInputToTypesafeClientTest.java

Thanks, much appreciated! :)

[lacoonte]

@jmartisk Took me more time than i thought as i had a busy week at work. Added two test cases to cover both issues. They fail on the main branch but pass on this one, let me know if there’s anything else I can improve :)

[jmartisk]

Thanks a lot!!!