Fix various issues related to Java 25 and run CI with Java 25 #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Java 25, the service class will be loaded by hasNext(), which makes the current pattern problematic. The new pattern makes sure we catch ClassNotFoundException with Java 25 and older versions.
|
Hum, I had the Gradle tests pass locally... having a closer look... |
|
OK, CI is happy now! |
|
Thanks a lot @gsmet! I will try to get a release out very soon (hopefully it will work!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in the way of testing Quarkus with Java 25 so I would appreciate a release once this is approved and merged :).
Thanks!