ClassCastException thrown by stream methods on Iterable types #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See smallrye#1188 The exception is thrown if the iterable type argument is a Vert.x API type. In this case, the type transformation is not applied (it's applied correctly for iterator methods). The fix consists in generating a stream method that uses the iterator from the generated type, instead of invoking the delegate directly.
Contributor
Author
|
@jponge can you please take a look? Thanks |
Member
|
/cc @anavarr (no action needed, but we'll need to check if the v5 generator supports these cases, because they appeared in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1188
The exception is thrown if the iterable type argument is a Vert.x API type.
In this case, the type transformation is not applied (it's applied correctly for iterator methods).
The fix consists in generating a stream method that uses the iterator from the generated type, instead of invoking the delegate directly.