Reproducer and fix for the groupBy operator upstream requests #2003
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The groupBy operator was not correctly managing upstream requests. It now makes prefetch amount of requests each time the drain loop does not emit any items. This commit includes both a reproducer and the fix for the issue.
ozangunalp
force-pushed
the
group_by_over_request
branch
from
2d7ad6e to
251d09f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
============================================
- Coverage 89.15% 89.08% -0.07%
+ Complexity 3070 3065 -5
============================================
Files 409 409
Lines 13100 13099 -1
Branches 1652 1652
============================================
- Hits 11679 11669 -10
- Misses 805 808 +3
- Partials 616 622 +6
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes prefetch amount of request each time drain loop does not emit any items
Seen in testing a solution for quarkusio/quarkus#50595