Performance improvements, replace several streams w/loops

[MikeEdgar]

For #2401

[gsmet]

@MikeEdgar so only changing streams to for loops makes such a huge difference?

[MikeEdgar]

@MikeEdgar so only changing streams to for loops makes such a huge difference?

@gsmet also the change in AugmentedIndexView is quite significant. Instead of asking the Jandex class for all methods and filtering the stream, it now asks for the method by name + parameter types. Most of the other changes to switch from streams to loops help with reducing the call depth and also make debugging/stepping through the scanner easier.

I think there is very likely to be some more room to improve how we use Jandex and possibly propose some features there to help out further.

[gsmet]

@MikeEdgar FYI I will push the new Jandex to next 3.29.z and 3.30.0.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.9% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

[MikeEdgar]

I think this should be ready to go now. It can be seen in the flame grapns how significant the reduction in parameter processing is with these changes. Thank you @Postremus for bringing up the issue.

Release 4.2.1: flamegraph-cpu-sropenapi-4.2.1.html (filtered to io.smallrye.openapi)

Changes in this PR: flamegraph-cpu-sropenapi-pr2404.html (filtered to io.smallrye.openapi)