Allow and handle negative credits, fixes invalid request number error #3197
Conversation
ozangunalp
left a comment
ozangunalp
left a comment
There was a problem hiding this comment.
Looks good to me. However, no matter what I do, I couldn't reproduce the negative credits.
|
@timterle ok for me. Could you sign your commits for me to merge the change ? Thank you! |
|
I managed to implement a test that triggers "invalid request number", but it runs for 6 seconds. I don't know if that is acceptable? |
|
@ozangunalp I tried to rebase and sign the commits, does it look ok for you? I don't see "Verified", maybe it's because I managed to commit using my git user at work, but making a pull request using my personal account. |
|
@timterle I think you signed-off but did not signed your commits. Here is the GH guide for it https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
timterle
force-pushed
the
main
branch
4 times, most recently
from
4cb7651 to
d386272
Compare
Signed-off-by: Tim Terlegård <[email protected]>
Signed-off-by: Tim Terlegård <[email protected]>
|
duplicate of #3213 |
3 participants
No description provided.