Use Pattern also for shared subscription without wildcards #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi guys, I don't know why Java 17 build failed, but it reports an error on SQS module that I didn't touck. It is possible to rerun the action? |
ozangunalp
approved these changes
Nov 5, 2025
Collaborator
|
@dometec Thanks for this change. Could you sign your commits for me to merge them? |
cescoffier
approved these changes
Nov 5, 2025
dometec
force-pushed
the
fix_share_subscription_without_wildcards
branch
from
9b8e58e to
fca7e2b
Compare
dometec
force-pushed
the
fix_share_subscription_without_wildcards
branch
from
fca7e2b to
a2706fb
Compare
Contributor
Author
|
Done, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regex Pattern is used for wildcard subscriptions to match topic's subscriptions (es: device/+/command) to topic's messages (es: device/SERIAL_1/command).
The Pattern usage is also need for shared subscritions, when a topic's subscriptions (es: $share/group/cloud/notification) have to match with a topic's messages (es: cloud/notification).