Replacement for #238 (Fix illegal encoding for MacRomanEncoding) (#313)

* try fix from @daneren2005 (from #238) to fix failing test in PHP 8.0
smalot · Jun 26, 2020 · bc4ebf8 · bc4ebf8
1 parent e886687
commit bc4ebf8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/samples/bugs/Issue229_mac_roman_encoding.pdf b/samples/bugs/Issue229_mac_roman_encoding.pdf
diff --git a/src/Smalot/PdfParser/Font.php b/src/Smalot/PdfParser/Font.php
@@ -482,7 +482,7 @@ public function decodeContent($text, &$unicode)
                     $text = $result;
 
                     if ($encoding->get('BaseEncoding')->equals('MacRomanEncoding')) {
-                        $text = mb_convert_encoding($text, 'UTF-8', 'Mac');
+                        $text = mb_convert_encoding($text, 'UTF-8', 'ISO-8859-1');
 
                         return $text;
                     }
@@ -495,7 +495,7 @@ public function decodeContent($text, &$unicode)
             if ($this->get('Encoding') instanceof Element &&
                 $this->get('Encoding')->equals('MacRomanEncoding')
             ) {
-                $text = mb_convert_encoding($text, 'UTF-8', 'Mac');
+                $text = mb_convert_encoding($text, 'UTF-8', 'ISO-8859-1');
             } else {
                 $text = mb_convert_encoding($text, 'UTF-8', 'Windows-1252');
             }