Handle multiple files in previous uploads, remove CSVs #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
approved these changes
May 12, 2025
| # If the latest uploads don't include this site, we'll use the last-valid | ||
| # one instead | ||
| try: | ||
| if not any(x.endswith(site_specific_name) for x in latest_file_list): | ||
| df = expand_and_concat_powersets(df, last_valid_path, last_valid_site) | ||
| if not any(subbucket_path in x for x in latest_file_list): |
There was a problem hiding this comment.
Is x.startswith(subbucket_path) equivalent for your purposes here? You know I hate a bare in check for strings.
There was a problem hiding this comment.
no, because the latest file will also have the basedir at the front. i could make this a regex but i personally hate that more than this kind of substring check.
| # otherwise, this is the first instance - after it's in the database, | ||
| # we'll generate a new list of valid tables for the dashboard | ||
| else: | ||
| is_new_data_package = True | ||
| df = expand_and_concat_powersets(df, latest_path, manager.site) | ||
| filename=functions.get_s3_filename(latest_path) |
There was a problem hiding this comment.
nit: is it worth adding filename to the s3 key parser method?
There was a problem hiding this comment.
I thought about this - the only time we ever really care (right now) is in this archive/unarchive case. but we could combine them.
dogversioning
force-pushed
the
mg/csv_duplicates
branch
from
0826e7a to
482c35e
Compare
dogversioning
force-pushed
the
mg/csv_duplicates
branch
from
482c35e to
cd488b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken up into three commits for my own sanity/testing isolation:
Commit one:
Commit two:
Commit three: