Fix for Growth Chart’s print functionality being extremely slow in IE. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : The open source version of growth chart pops out a window for the print functionality. When the application is run in IE, launching the print window opens up the pop-up but the content is rendered extremely slow. This results in the user staring at a blank page for several seconds and sometimes minutes before any UI gets rendered on the screen. This gives the user an impression that the UI is stuck.
More Info on this Issue : #26
Fix : This PR fixes the slowness issue. The fix involves loading content on the popup window from the main growth chart window.
Changes :
A new gc-print.html page is loaded when we click on the Print Icon on Main window.
The Main GC window uses the rendered "Graph" and "Parent" views from the main window to be shown on the print popup based on the selection on the main window. If "Table" view is selected on the main window we redraw the table in a vertical orientation on the print popup.
**Printing Considerations/Instructions : **
The user will need to print in landscape mode for Graph and Parent views where as portrait mode can be used for Table view.