Add CCTPv2TokenDataObserver integration tests #1406
+1,491
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstout
force-pushed
the
cctpv2-observer-integration-tests
branch
3 times, most recently
from
219680a to
5b49a33
Compare
40 test scenarios, tests edge cases
rstout
force-pushed
the
cctpv2-observer-integration-tests
branch
from
5b49a33 to
14cf277
Compare
rstout
requested review from
KodeyThomas,
agusaldasoro,
b-gopalswami,
mateusz-sekara,
ogtownsend,
tt-cll and
winder
mateusz-sekara
previously approved these changes
Nov 21, 2025
|
|
||
| // Helper function to create a complete CCTPv2Message with a specific unique ID | ||
| // The uniqueID is used to make messages distinct from each other | ||
| func createCircleMessageWithID(uniqueID byte, status string) CCTPv2Message { |
Collaborator
There was a problem hiding this comment.
nit, If you don't rely on asserting uniqueID anywhere in the code, I guess you can make it randomized for simplicity. We have helpers for that in code, i.e., RandomBytes32, RandomAddress, RandomHash
Contributor
Author
There was a problem hiding this comment.
The uniqueID determines the DepositHash of these CCTPv2 messages, they are indirectly used. I think it's best to keep things deterministic
|
ogtownsend
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
40 test scenarios, tests edge cases