FeeQuoter simplification, fix non-evm & apply link discount #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RensR
commented
Nov 21, 2025
| import {Client} from "../libraries/Client.sol"; | ||
| import {Internal} from "../libraries/Internal.sol"; | ||
|
|
||
| interface ILegacyFeeQuoter { |
Collaborator
Author
There was a problem hiding this comment.
Extracted to clearly show what can be removed in future versions and what doesn't have to be written for net-new non-evms
kylesmartin
reviewed
Nov 21, 2025
chains/evm/contracts/FeeQuoter.sol
Outdated
| // Apply the premium multiplier for the fee token, making it 36 decimals | ||
| premiumFeeUSDWei *= s_feeTokens.get(message.feeToken); | ||
| if (message.feeToken == i_linkToken) { | ||
| premiumFeeUSDWei *= 9e17; // 0.9x for LINK |
Contributor
There was a problem hiding this comment.
Replace configurable fee token based discount with hard coded value
Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most outstanding issues in the FeeQuoter. Due to the PR structure it's best to review each commit individually instead of the final result. Almost all functions in the feeQuoter have moved to clearly split legacy functions from 1.7 required functionality.