Skip to content

Clean up spam native token address logs#1411

Merged
ogtownsend merged 6 commits intomainfrom
ogt/clean-up-spammy-logs
Nov 26, 2025
Merged

Clean up spam native token address logs#1411
ogtownsend merged 6 commits intomainfrom
ogt/clean-up-spammy-logs

Conversation

@ogtownsend
Copy link
Contributor

  • Dropping Native token address is zero or empty. Ignore for disabled chains otherwise check for router misconfiguration to debug since it shows up for invalid/not supported lane combinations
  • See previous discussions here
  • The core issue is there's a gap between what the plugin reads as supportedChains from CCIPHome and what chains are actually configured in the dest chain's offramp source chain configs. supportedChains seems to be a superset of the actually supported source chains according to the OffRamp's source chain configs
  • This PR also cleans up some logs in the DefaultAccessor

@github-actions
Copy link

👋 ogtownsend, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

makramkd
makramkd previously approved these changes Nov 22, 2025
Copilot AI review requested due to automatic review settings November 24, 2025 17:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise by downgrading several log levels from warn/info to debug, particularly for expected scenarios like unsupported chain combinations and skipped configuration requests. The main change addresses spam from native token address warnings that occur for invalid/unsupported lane combinations where the supportedChains from CCIPHome is a superset of actually configured source chains.

Key changes:

  • Downgraded native token address warning to debug level in ccip.go
  • Standardized logger initialization and cleaned up redundant context fields in default_accessor.go
  • Added helper function to check for no bindings errors in observation.go

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pkg/reader/ccip.go Downgraded native token address log from warn to debug to reduce spam for unsupported lanes
pkg/chainaccessor/default_accessor.go Standardized logger with chain context, removed redundant log fields, and downgraded skipped config warning to debug
commit/merkleroot/observation.go Added helper function to check for no bindings errors including string matching

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

makramkd
makramkd previously approved these changes Nov 24, 2025
@ogtownsend ogtownsend enabled auto-merge November 25, 2025 03:48
@github-actions
Copy link

Metric ogt/clean-up-spammy-logs main
Coverage 69.7% 70.1%

@ogtownsend ogtownsend added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@ogtownsend ogtownsend added this pull request to the merge queue Nov 26, 2025
Merged via the queue into main with commit de22087 Nov 26, 2025
55 checks passed
@ogtownsend ogtownsend deleted the ogt/clean-up-spammy-logs branch November 26, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants