Clean up spam native token address logs#1411
Conversation
|
👋 ogtownsend, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise by downgrading several log levels from warn/info to debug, particularly for expected scenarios like unsupported chain combinations and skipped configuration requests. The main change addresses spam from native token address warnings that occur for invalid/unsupported lane combinations where the supportedChains from CCIPHome is a superset of actually configured source chains.
Key changes:
- Downgraded native token address warning to debug level in ccip.go
- Standardized logger initialization and cleaned up redundant context fields in default_accessor.go
- Added helper function to check for no bindings errors in observation.go
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/reader/ccip.go | Downgraded native token address log from warn to debug to reduce spam for unsupported lanes |
| pkg/chainaccessor/default_accessor.go | Standardized logger with chain context, removed redundant log fields, and downgraded skipped config warning to debug |
| commit/merkleroot/observation.go | Added helper function to check for no bindings errors including string matching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Native token address is zero or empty. Ignore for disabled chains otherwise check for router misconfigurationto debug since it shows up for invalid/not supported lane combinationssupportedChainsseems to be a superset of the actually supported source chains according to the OffRamp's source chain configsDefaultAccessor