Clarify log statements in exec logs #1572
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogtownsend
commented
Jan 16, 2026
Comment on lines
+169
to
+175
| // Only log if the message is part of the report and not already executed, | ||
| // since pseudo-deletion for executed messages is expected behavior. | ||
| isAlreadyExecuted := slices.Contains(report.ExecutedMessages, msg.Header.SequenceNumber) | ||
| isPartOfReport := report.SequenceNumberRange.Contains(msg.Header.SequenceNumber) | ||
| if isPartOfReport && !isAlreadyExecuted { | ||
| lggr.Infow("message pseudo deleted", "index", idx, "messageID", msg.Header.MessageID) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@makramkd is this what you had in mind for CCIP-8317 ?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCIP-8318
CCIP-8317