Merged
Conversation
ogtownsend
commented
Jan 16, 2026
Comment on lines
+169
to
+175
| // Only log if the message is part of the report and not already executed, | ||
| // since pseudo-deletion for executed messages is expected behavior. | ||
| isAlreadyExecuted := slices.Contains(report.ExecutedMessages, msg.Header.SequenceNumber) | ||
| isPartOfReport := report.SequenceNumberRange.Contains(msg.Header.SequenceNumber) | ||
| if isPartOfReport && !isAlreadyExecuted { | ||
| lggr.Infow("message pseudo deleted", "index", idx, "messageID", msg.Header.MessageID) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@makramkd is this what you had in mind for CCIP-8317 ?
|
makramkd
approved these changes
Jan 20, 2026
ogtownsend
requested review from
AmrMohamedRezk,
agusaldasoro,
asoliman92,
b-gopalswami,
Copilot,
matYang,
tt-cll and
winder
and removed request for
Copilot
winder
approved these changes
Jan 20, 2026
ogtownsend
deleted the
CCIP-8318-add-more-info-to-more-than-one-conensus-msg-log
branch
RensR
added a commit
that referenced
this pull request
Feb 2, 2026
* Bump Go deps and fix NPM deps (#1570) * carpenter * Delete package-lock.json * rm unused override * move to dev deps * [CRE-491] Bump common and other deps (#1576) * gomods. * gomods. * Minor. * Code (#1562) * Add more clear instructions to seqno consensus failure log (#1572) * CCIP-8527: Adding operations and sequences for token governor contract (#1579) * CCIP-8527: Adding operations and sequences for token governor contract * review comment * review commnet -ai * [CRE-491] Delete unused consts pkg (instead we use its copy from common) (#1577) * Minor. * Minor. * Minor. * chore: trigger pipeline * chore: trigger pipeline * Minor. * chore: trigger pipeline * Minor. * Minor. * Minor. * chore: trigger pipeline * Add GasLimit to commit offchain config (#1598) * Add GasLimit to commit offchain plugin * rename to EVMGasLimit * error on the commit plugin if rmn is enabled (#1587) * error on the commit plugin if rmn is enabled * fix tests * update test * Ccip-8991 one environment for forked and local chains (#1595) * one environment * updates * Ccip-8552 Adding metadata as onchain output (#1601) * adding metadata as onchain output * matching with develop * handle conflicts * Clean up lots of dead/deprecated CCIPReader code (#1573) * Clean up lots of dead CCIPReader code * lint and regen * fix processor test * lint and fix more tests * make generate * update discovery tests * Migrate devenv to test adapters (#1589) * Migrate devenv to test adapters * fixes: EVM tests and Solana->EVM pass again * fix gas limits * Fix solana->evm and evm->solana * Revert change * goimports -w -local github.com/smartcontractkit/chainlink-ccip . * Remove local replaces * go mod fixup * fix lint * Deduplicate code * Fix lints * Fix some of the solana lints * cleanup * Remove unnecessary generics * feat: implement token api for evm 1.6 (#1588) * feat: implement token api for evm 1.6 * feat: add integration test, refactor evm token adapter impl, fix token pool qualifier bug * chore: reword comment * fix: do not use token symbol for token pool qualifier * chore: add more EVM token expansion checks * fix: gomodtidy * chore: add more comments and refactor GetToken calls * Refactor go bindings and deployment evm (#1578) * Refactor go bindings and deployment evm * fix ping pong * Fix tests * Fix mock Import * review comments * Replace factory bnmerc20 with bnmerc20 * more test has factory bnmerc20 * Remove option to deploy factory_burn_mint_erc20 directly * lint fix * make generate * go sum * Fix mocks * Fix imports * Use correct token for testing * Modify owner * Test --------- Co-authored-by: Balamurali Gopalswami <balamurali.gopalswami@smartcontract.com> * bump cl-ton version and update tooling adapter (#1604) * bump cl-ton version and update tooling adapter * bump dependency for devenv * bump mod * update modgraph --------- Co-authored-by: Jonghyeon Park <jadepark.dev@gmail.com> * bump mcms, fix ref (#1609) --------- Co-authored-by: pavel-raykov <165708424+pavel-raykov@users.noreply.github.com> Co-authored-by: Oliver Townsend <133903322+ogtownsend@users.noreply.github.com> Co-authored-by: Balamurali Gopalswami <167726375+b-gopalswami@users.noreply.github.com> Co-authored-by: Abdelrahman Soliman (Boda) <2677789+asoliman92@users.noreply.github.com> Co-authored-by: Austin <107539019+0xAustinWang@users.noreply.github.com> Co-authored-by: Anindita Ghosh <88458927+AnieeG@users.noreply.github.com> Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Chris De Leon <147140544+chris-de-leon-cll@users.noreply.github.com> Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com> Co-authored-by: Balamurali Gopalswami <balamurali.gopalswami@smartcontract.com> Co-authored-by: Joe Huang <joe.huang@smartcontract.com> Co-authored-by: Jonghyeon Park <jadepark.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCIP-8318
CCIP-8317