Refactor go bindings and deployment evm #1578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agusaldasoro
commented
Jan 19, 2026
|
|
||
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/deployment/utils/operations/contract" | ||
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/latest/factory_burn_mint_erc20" | ||
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/v1_5_1/factory_burn_mint_erc20" |
Contributor
Author
There was a problem hiding this comment.
There is no smaller version of that binding, is this okay?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the EVM deployment codebase to remove support for ERC677 and BurnMintERC677 token types, and transitions from using "latest" contract bindings to explicit versioned package imports. This improves maintainability by ensuring consistent contract versions and simplifies the token deployment logic.
Changes:
- Removed ERC677 and BurnMintERC677 token deployment support from token sequences and tests
- Updated import paths from
latestto specific versions (v1_5_0, v1_5_1, v1_6_0, v1_6_2, v1_6_4) - Fixed type conversion issues in ping_pong_dapp operations
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chains/evm/deployment/v1_6_4/changesets/usdc_token_pool_cctp_v2_deploy_test.go | Updated imports to use versioned bindings instead of latest |
| chains/evm/deployment/v1_6_4/changesets/set_domains_test.go | Updated imports to use versioned bindings instead of latest |
| chains/evm/deployment/v1_6_4/changesets/modify_remote_pools_test.go | Updated factory_burn_mint_erc20 import to v1_5_1 |
| chains/evm/deployment/v1_6_4/changesets/apply_chain_updates_test.go | Moved factory_burn_mint_erc20 import from latest to v1_6_2 |
| chains/evm/deployment/v1_6_0/sequences/token_test.go | Removed ERC677 and BurnMintERC677 test cases and imports |
| chains/evm/deployment/v1_6_0/sequences/token.go | Removed ERC677 and BurnMintERC677 deployment logic and updated comments |
| chains/evm/deployment/v1_6_0/operations/ping_pong_dapp/ping_pong_dapp.go | Updated binding import to v1_5_0 and added BytesToAddress conversions |
| chains/evm/deployment/v1_0_0/sequences/mcms.go | Updated burn_mint_erc677 import to initial version |
| chains/evm/deployment/v1_0_0/operations/factory_burn_mint_erc20/factory_burn_mint_erc20.go | Updated import to v1_5_1 |
| chains/evm/deployment/v1_0_0/operations/erc677/erc677.go | Deleted entire file (removed ERC677 deployment operation) |
| chains/evm/deployment/v1_0_0/operations/burn_mint_erc677/burn_mint_erc677.go | Deleted entire file (removed BurnMintERC677 deployment operation) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/latest/factory_burn_mint_erc20" | ||
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/v1_5_1/burn_mint_token_pool" | ||
| token_pool_bindings "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/v1_5_1/token_pool" | ||
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/v1_6_2/factory_burn_mint_erc20" |
There was a problem hiding this comment.
The factory_burn_mint_erc20 import is using v1_6_2 here, but in modify_remote_pools_test.go (line 25) the same package is imported from v1_5_1. This inconsistency in versioning across test files could lead to unexpected behavior. Consider standardizing to the same version across all test files in the v1_6_4 changesets directory.
Suggested change
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/v1_6_2/factory_burn_mint_erc20" | |
| "github.com/smartcontractkit/chainlink-ccip/chains/evm/gobindings/generated/v1_5_1/factory_burn_mint_erc20" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for ERC677 and BurnMintERC677 token deployments from the EVM deployment codebase, updates related documentation and tests, and switches contract bindings to use explicit versioned packages instead of "latest". These changes simplify the token deployment logic and improve maintainability by ensuring consistent contract versions.
Copied the
mock_usdc_token_messengerandmock_usdc_token_transmitterfolders to their corresponding folder so they can be referenced without using latest.