Add withdrawFeeTokens changeset for EVM fee-handling contracts#1792
Open
finleydecker wants to merge 1 commit intodevelopfrom
Open
Add withdrawFeeTokens changeset for EVM fee-handling contracts#1792finleydecker wants to merge 1 commit intodevelopfrom
finleydecker wants to merge 1 commit intodevelopfrom
Conversation
kylesmartin
previously approved these changes
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “withdraw fee tokens” workflow for EVM fee-handling contracts, enabling batched withdrawals across OnRamp, CommitteeVerifier, and TokenPool variants via an MCMS proposal.
Changes:
- Adds an auto-generated
withdrawFeeTokenswrite operation for the EVM OnRamp (v1.6.0 ops) and registers it in the ops-gen config. - Introduces a v1.7.0 sequence + changeset that routes withdrawals by contract type and batches results into a single MCMS batch operation.
- Adds Go tests covering precondition validation and non-pool withdrawal paths (OnRamp / CommitteeVerifier) plus TokenPool recipient validation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| chains/evm/deployment/v1_6_0/operations/onramp/onramp.go | Adds OnRamp withdrawFeeTokens contract method wrapper and write operation. |
| chains/evm/deployment/operations_gen_config.yaml | Registers withdrawFeeTokens as an owner-only OnRamp operation for generation. |
| ccv/chains/evm/deployment/v1_7_0/sequences/withdraw_fee_tokens.go | Adds routing + batching sequence for fee-token withdrawals across contract types. |
| ccv/chains/evm/deployment/v1_7_0/operations/onramp/on_ramp.go | Removes redundant v1.7.0 OnRamp withdraw operation in favor of v1.6.0 generated op. |
| ccv/chains/evm/deployment/v1_7_0/changesets/withdraw_fee_tokens.go | Adds changeset wrapper resolving datastore refs into sequence input. |
| ccv/chains/evm/deployment/v1_7_0/changesets/withdraw_fee_tokens_test.go | Adds tests for validation + OnRamp/CommitteeVerifier apply paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccv/chains/evm/deployment/v1_7_0/changesets/withdraw_fee_tokens.go
Outdated
Show resolved
Hide resolved
d1b2888 to
6072839
Compare
6072839 to
1f54830
Compare
All operations use auto-generated latest/operations/ packages. Includes OnRamp, CommitteeVerifier, and all 11 TokenPool variant types.
1f54830 to
89e3497
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latest/operations/for all contract operations (no manual ops)Example inputs (can also batch)