Upgrade anchor #939
Draft
Upgrade anchor #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusaldasoro
commented
May 20, 2025
| } | ||
|
|
||
| #[derive(AnchorSerialize, AnchorDeserialize, Clone, Debug)] | ||
| pub struct Ocr3ConfigInfoInput { |
Contributor
Author
There was a problem hiding this comment.
@jadepark-dev Does this change make sense? I copied it from your branch, I'm not sure if I should do the same to all the structs that I had to remove the AnchorSerialize and AnchorDeserialize?
Contributor
There was a problem hiding this comment.
No, iirc it was only for Ocr3ConfigInfo. This could be a bug from Anchor. They changed AnchorSerialize, AnchorDeserialize to be implemented automatically from 0.30.x, but the compiler was complaining when it's used for input struct so I had to split the struct and give it those attributes.
But please keep in mind that the work was experimental, so it might have been fixed in a more recent version of Anchor or there might be a better pattern now!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build contracts with latest version of anchor 0.31.0 running
make build-contracts.The go-bindings are not working right now, as a few changes need to be done.